Update to latest v2 develop branch

[tznind]

Outstanding issues

• Esc in 'save changes' dialog should select cancel
• v2 Nuget package numbering has reset somehow Terminal.Gui#3779
• Colors in dialogs are super confusing, grey on grey. We should switch all the TGD ones to the Yes/No colors with bright yellow to select - lovely.
• ContextMenus now broken in v2 net and win drivers Terminal.Gui#3986
• TimeField does not implement Dim.Auto correctly Terminal.Gui#3975
  • TimeField should probably be auto width - but it also seems broken for dim auto
  • Temporarily fixed by seting explicit size for this view in ViewFactory
• TabView steals keypresses from active ContextMenu Terminal.Gui#3974
  • Add a tab view
  • Right click elsewhere
  • Try to navigate context menu
  • TabView steals the cursor presses
• Don't let user add any of the following as they are internal views not meant for user consumption
  • Tab
  • Bar
  • CharMap (this thing destroys performance - height 75,352 !)
  • LegendAnnotation
  • Menuv2
  • ScrollBar
  • ScrollSlider
  • TileView (Not really usable yet)
• Do not let user select base SpinnerType for SpinnerView

Cannot create abstract

• DatePicker should be width/height dim auto (also support any relevant designable properties)

• ComboBox does not let you design its items (did this used to work?)

• Trying to set shortcut key on status bar item gives null reference

  • Add status bar
  • Delete default item
  • Add new item
  • Right click and select set shortcut
  • See error

• PosEditor - PosRelative combo boxes are basically broken, consider autocoplete text box instead or radio buttons. Terminal.Gui combos are just bad

• Null Reference in DoDrawBorderAndPadding Terminal.Gui#3964 (using help while in a menu)

• Cannot exit a Window with a CanFocus true MenuBar Terminal.Gui#3965

• File dialog listbox overlaps with buttons Terminal.Gui#3967

• Can trigger a crash by doing the following when editing a menu (only seems to affect blank menus for some reason)

  • Add a blank menu
  • Add another blank menu below
  • Shift+Right to move to sub menu
  • Press right to expand the menus

System.IndexOutOfRangeException: 'Index was outside the bounds of the array.'


 	Terminal.Gui.dll!Terminal.Gui.MenuBar.NextMenu(bool isSubMenu, bool ignoreUseSubMenusSingleFrame)	Unknown
 	Terminal.Gui.dll!Terminal.Gui.Menu.BeginInit.AnonymousMethod__5_0()	Unknown
 	Terminal.Gui.dll!Terminal.Gui.View.InvokeCommands<Terminal.Gui.KeyBinding>(Terminal.Gui.Command[] commands, Terminal.Gui.KeyBinding binding)	Unknown
 	Terminal.Gui.dll!Terminal.Gui.View.InvokeCommands(Terminal.Gui.Key key)	Unknown
 	Terminal.Gui.dll!Terminal.Gui.View.NewKeyDownEvent(Terminal.Gui.Key key)	Unknown
 	Terminal.Gui.dll!Terminal.Gui.View.NewKeyDownEvent(Terminal.Gui.Key key)	Unknown
 	Terminal.Gui.dll!Terminal.Gui.Application.RaiseKeyDownEvent(Terminal.Gui.Key key)	Unknown
 	Terminal.Gui.dll!Terminal.Gui.Application.Driver_KeyDown(object sender, Terminal.Gui.Key e)	Unknown
 	Terminal.Gui.dll!Terminal.Gui.WindowsInputProcessor.Process(Terminal.Gui.WindowsConsole.InputRecord inputEvent)	Unknown
 	Terminal.Gui.dll!Terminal.Gui.InputProcessor<Terminal.Gui.WindowsConsole.InputRecord>.ProcessQueue()	Unknown
 	Terminal.Gui.dll!Terminal.Gui.MainLoop<Terminal.Gui.WindowsConsole.InputRecord>.IterationImpl()	Unknown
 	Terminal.Gui.dll!Terminal.Gui.MainLoop<Terminal.Gui.WindowsConsole.InputRecord>.Iteration()	Unknown
 	Terminal.Gui.dll!Terminal.Gui.ApplicationV2.Run(Terminal.Gui.Toplevel view, System.Func<System.Exception, bool> errorHandler)	Unknown
 	Terminal.Gui.dll!Terminal.Gui.Application.Run(Terminal.Gui.Toplevel view, System.Func<System.Exception, bool> errorHandler)	Unknown
>	TerminalGuiDesigner.dll!TerminalGuiDesigner.UI.Editor.Run(TerminalGuiDesigner.Options options) Line 221	C#
 	TerminalGuiDesigner.dll!TerminalGuiDesigner.Program.Main.AnonymousMethod__0_0(TerminalGuiDesigner.Options o) Line 25	C#
 	CommandLine.dll!CommandLine.ParserResultExtensions.WithParsed<TerminalGuiDesigner.Options>(CommandLine.ParserResult<TerminalGuiDesigner.Options> result, System.Action<TerminalGuiDesigner.Options> action)	Unknown
 	TerminalGuiDesigner.dll!TerminalGuiDesigner.Program.Main(string[] args) Line 18	C#

• Click events need to be Esc or they trigger defaults

• Color editor is probably dubious

• Add view does not focus search box properly

• Adding views shows full class name (has always been this bad?!)

• There is a broken behaviour when editing sliders with shadow adornment. After adding option in array editor things seem to soft break and not save

• Adornment test is breaking in CI (fixed, unit test had out of date package)

    /// <summary>
    /// Gets the <see cref="Color"/> to use for <see cref="ColorScheme.Disabled"/> <see cref="Attribute.Foreground"/>.
    /// </summary>
    [JsonConverter(typeof(JsonStringEnumConverter<Color> ))]
    [YamlMember( typeof(Color), ScalarStyle = ScalarStyle.Plain, DefaultValuesHandling = DefaultValuesHandling.Preserve)]
    public Color DisabledForeground { get; init; } = DisabledForeground;

• Need to be able to serialize Color.Red as "red" and deserialize again sensibly for both json and yaml now that there are no ColorNames
• View.FindDeepestView(w, m.Position); is gone
  • Ok seems to be replaced by View.GetViewsUnderMouse (mouseEvent.ScreenPosition)
• Drag select does not render
• Cannot drag resize buttons because of Margin/Shadow

[tznind]

Copied from closed PR

• Adding a DateTimeField implicitly adds a sibling Popup view too resulting in 2 views being added. Likely as a result of Popover - A consistent way of enabling a Subview to popup outside of a View Terminal.Gui#3691 and/or Fixes #3750 - MouseEnter/Leave Terminal.Gui#3751

• Keyboard navigation and accept in confirm dialog is broken:
  
  Pressing Enter does nothing, neither does space or tab. Only clicking buttons triggers

[tznind]

I have added logging and target v2 driver.

[tznind]

ComboBox does not work and honestly never has. It should hopefully get fixed in the gui-cs/Terminal.Gui#3852

In the mean time I have marked it as not supported view in TGD and switched pos relative (the only place we use combo box in TGD) to use radio group and text box with autocomplete instead:

[tznind]

@BDisp ok think this is good to go, I've kicked the tyres a lot and think I have found all the bugs and they've been fixed upstream. Give it a go and see if you can find any other bugs and if not lets ship it!

Hmn actually there is still

• TabView steals keypresses from active ContextMenu Terminal.Gui#3974 :/ that one is a bit janky

Yeah that is a dealbreaker. As soon as you add a TabView to the Window it breaks keyboard navigation in context menu very badly.

[BDisp]

I did my best in the PR gui-cs/Terminal.Gui#3995. I hope fixed that. Then it's all good to go on.

[tznind]

I'm still seeing Views getting key presses while context menu is open... I will have to experiment in core Terminal.Gui and see if its something about the designer or just general issue with context menu.

It only kicks in after adding a TabView, does tab view somehow use grab mouse or what makes it break the normal focus systems that make context menu behave? Any ideas @BDisp ?

Hmn actually I might be using stale dependency

[BDisp]

Now I don't think so. Do you have same repo code that I can investigate?

[tznind]

Its working, I had updated showcase and version numbers in csproj but not the package version on the csproj 🤦

[tznind]

Its live! Or at least should be soon.

Pushing TerminalGuiDesigner.2.0.0-develop.4400.nupkg to 'https://www.nuget.org/api/v2/package'...
  PUT https://www.nuget.org/api/v2/package/
  Created https://www.nuget.org/api/v2/package/ 1520ms
Your package was pushed.