Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore upgrade tekton pipelines #1621

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

JordanGoasdoue
Copy link
Contributor

@JordanGoasdoue JordanGoasdoue commented Dec 6, 2024

related to jenkins-x/jx#8683

@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@JordanGoasdoue JordanGoasdoue force-pushed the chore-upgrade-tekton-pipelines branch 7 times, most recently from b22abab to 45cc04d Compare December 9, 2024 18:40
@msvticket
Copy link
Member

According to https://github.com/tektoncd/pipeline/blob/main/docs/deprecations.md#v1beta1-deprecation the v1beta1 versions will be supported by tekton for a couple of years. So we should be able to support v1 and v1beta1 at the same time for a while, making the transition easier for us and our users.

There seems to be code to convert from v1beta1 to v1. For example: https://github.com/tektoncd/pipeline/blob/main/pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go

I think the easiest would be to use such methods in pkg/triggerconfig/inrepo/load_pipelinerun.go if apiVersion is tekton.dev/v1beta1 in the file.

@msvticket
Copy link
Member

/retest

@JordanGoasdoue
Copy link
Contributor Author

@msvticket thank you will check this

@JordanGoasdoue JordanGoasdoue force-pushed the chore-upgrade-tekton-pipelines branch from 45cc04d to 3a23abc Compare March 17, 2025 10:52
@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jordangoasdoue
You can assign the PR to them by writing /assign @jordangoasdoue in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JordanGoasdoue JordanGoasdoue force-pushed the chore-upgrade-tekton-pipelines branch 10 times, most recently from 2d9af2f to 5105afc Compare March 17, 2025 14:40
@JordanGoasdoue JordanGoasdoue force-pushed the chore-upgrade-tekton-pipelines branch from 3ff3c74 to 61d3f7a Compare March 18, 2025 15:08
@JordanGoasdoue JordanGoasdoue force-pushed the chore-upgrade-tekton-pipelines branch 2 times, most recently from 4e30fb2 to 115586c Compare March 19, 2025 10:43
@JordanGoasdoue JordanGoasdoue force-pushed the chore-upgrade-tekton-pipelines branch from 115586c to 1345fd5 Compare March 19, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants