Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forget_forced_upon_leave capability as per MSC4267 #4732

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Add forget_forced_upon_leave capability as per MSC4267 #4732

wants to merge 2 commits into from

Conversation

Johennes
Copy link
Contributor

This adds the capability from matrix-org/matrix-spec-proposals#4267.

Synapse PR: element-hq/synapse#18196

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Feb 28, 2025
@Johennes Johennes mentioned this pull request Feb 28, 2025
Open
@Johennes Johennes marked this pull request as ready for review February 28, 2025 11:38
@Johennes Johennes requested a review from a team as a code owner February 28, 2025 11:38
t3chguy
t3chguy reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming confused me, have raised a point in https://github.com/matrix-org/matrix-spec-proposals/pull/4267/files#r1975272642

@Johennes
Copy link
Contributor Author

The naming confused me, have raised a point in https://github.com/matrix-org/matrix-spec-proposals/pull/4267/files#r1975272642

This is great, thank you. I literally just wanted to leave a comment saying that I'd be happy to receive suggestions for better naming of the capability. 😅

@Johennes Johennes marked this pull request as draft February 28, 2025 11:46
@Johennes Johennes changed the title Add leave_without_forget capability as per MSC4267 Add forget_forced_upon_leave capability as per MSC4267 Feb 28, 2025
@Johennes Johennes marked this pull request as ready for review February 28, 2025 12:32
@t3chguy
Copy link
Member

t3chguy commented Mar 13, 2025

@Johennes looks like more concerns have been raised in the MSC re the naming, are you happy for this PR to wait until those are settled or do you desire this to land before FCP?

@richvdh also raised the point oob that the new symbol warrants some TSDoc

@Johennes Johennes marked this pull request as draft March 13, 2025 10:20
@Johennes
Copy link
Contributor Author

Sorry, I should have put this back into draft state after getting approval. I'm fine with this lingering until the MSC lands (or is rejected). If this moves forward, I'll make sure to add the missing docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Johennes @t3chguy