MSC4267: Automatically forgetting rooms on leave #4267
Conversation
Johennes
changed the title
Signed-off-by: Johannes Marbach <[email protected]>
Johennes
force-pushed
the
johannes/auto-forget
branch
from
200212f to
afb15ec
Compare
turt2live
added
proposal
There was a problem hiding this comment.
Implementation requirements:
- Client
- Server
There was a problem hiding this comment.
Server: element-hq/synapse#18196
There was a problem hiding this comment.
Client: matrix-org/matrix-js-sdk#4732
There was a problem hiding this comment.
conduwuit server implementation:
girlbossceo/conduwuit@35981d5
girlbossceo/conduwuit@c8a730c
proposals/4267-auto-forget.md
Outdated
| ``` json5 | ||
| { | ||
| "capabilities": { | ||
| "m.leave_without_forget": { |
There was a problem hiding this comment.
I got hung up on this naming. m.leave_implicit_forget or m.leave_auto_forget maybe? Leave without forget sounds like its doing the opposite of
Therefore, servers that
auto-forget rooms MUST advertise that they do so via anm.leave_without_forget
capability.
There was a problem hiding this comment.
Yeah, the current naming is a bit odd. I was thinking of the capability as "I can leave a room without forgetting it" but that makes it reciprocal to auto-forgetting rooms on the server.
You could also think of it inversely like in your suggestion as "I can leave and forget a room in one operation". My only concern with this was that when the capability is enabled, a client actually has less choice. It's not actually that you can leave and forget in one operation but rather that you must.
Maybe I'm just overthinking it though. 😵💫
There was a problem hiding this comment.
m.forget_forced_upon_leave maybe?
There was a problem hiding this comment.
I like that. It's not reciprocal and expresses the coercion aspect. 👍
There was a problem hiding this comment.
it's a bit clunky though - how about just m.forced_forget?
There was a problem hiding this comment.
My only concern is that we may be unduly confident because Synapse has had the config option forget_rooms_on_leave for a long time now. The problem is it defaults to false, so I would like to hear from some people who have been using that option successfully.
| @@ -0,0 +1,70 @@ | |||
| # MSC4267: Automatically forgetting rooms on leave | |||
There was a problem hiding this comment.
This looks very sensible to me, fwiw. I don't think we need further proof of implementation between 2x servers, given it's also pretty trivial to envisage how it'd work; I suggest we FCP it.
Rendered
Fixes: matrix-org/matrix-spec#447
In line with matrix-org/matrix-spec#1700, the following disclosure applies:
I am a Systems Architect at gematik, Software Engineer at Unomed, Matrix community member and former Element employee. This proposal was written and published with my gematik hat on.