Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: e2e: use images built with dependencies #1006

Merged
merged 1 commit into from
Mar 13, 2025
Merged

NO-JIRA: e2e: use images built with dependencies #1006

merged 1 commit into from
Mar 13, 2025

Conversation

hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Mar 11, 2025 •
edited
Loading

This simplifies the builds in CI run.

Requires openshift/release#62541

The images are built on ota-stage and pushed (to test this PR) to my own repo from quay.io: The job is green.

$ oc image mirror --keep-manifest-list=true default-route-openshift-image-registry.apps.ota-stage.q2z4.p1.openshiftapps.com/hongkliu-test/rust:e2e-test-ubi9=quay.io/hongkliu/test:rust-e2e-test-ubi9 default-route-openshift-image-registry.apps.ota-stage.q2z4.p1.openshiftapps.com/hongkliu-test/rust:ubi9=quay.io/hongkliu/test:rust-ubi9 -a /tmp/p.c

@hongkailiu hongkailiu changed the title e2e: use images buit with dependencies [wip]e2e: use images buit with dependencies Mar 11, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2025
@hongkailiu
Copy link
Member Author

/retest

@hongkailiu hongkailiu force-pushed the e2e-test-from branch 2 times, most recently from 3ca77fd to 47556ec Compare March 11, 2025 23:53
@hongkailiu
Copy link
Member Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2025
@hongkailiu hongkailiu changed the title [wip]e2e: use images buit with dependencies e2e: use images buit with dependencies Mar 11, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2025
@hongkailiu hongkailiu changed the title e2e: use images buit with dependencies e2e: use images built with dependencies Mar 11, 2025
@hongkailiu hongkailiu changed the title e2e: use images built with dependencies NO-JIRA: e2e: use images built with dependencies Mar 12, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 12, 2025
@openshift-ci-robot
Copy link

@hongkailiu: This pull request explicitly references no jira issue.

In response to this:

This simplifies the builds in CI run.

Requires openshift/release#62541

The images are built on ota-stage and pushed (to test this PR) to my own repo from quay.io: The job is green.

$ oc image mirror --keep-manifest-list=true default-route-openshift-image-registry.apps.ota-stage.q2z4.p1.openshiftapps.com/hongkliu-test/rust:e2e-test-ubi9=quay.io/hongkliu/test:rust-e2e-test-ubi9 default-route-openshift-image-registry.apps.ota-stage.q2z4.p1.openshiftapps.com/hongkliu-test/rust:ubi9=quay.io/hongkliu/test:rust-ubi9 -a /tmp/p.c

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hongkailiu hongkailiu mentioned this pull request Mar 12, 2025
Merged
@hongkailiu
Copy link
Member Author

/cc @petr-muller

@openshift-ci openshift-ci bot requested a review from petr-muller March 13, 2025 13:50
@hongkailiu
Copy link
Member Author

/retest-required

petr-muller
petr-muller approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice simplification 👍

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 13, 2025

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hongkailiu
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit d6c64b4 into openshift:master Mar 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petr-muller petr-muller petr-muller approved these changes

Assignees

@petr-muller petr-muller

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongkailiu @openshift-ci-robot @petr-muller