Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top bar improvements #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Top bar improvements #12

wants to merge 3 commits into from

Conversation

Rylern
Copy link
Collaborator

@Rylern Rylern commented Mar 21, 2025

Address #10 by:

  • Updating the combobox to reflect the currently-open page.
  • Putting the top bar on one horizontal line.

@petebankhead
Copy link
Member

petebankhead commented Mar 21, 2025

I like the saved space (current screenshot below, for 'before' see #10 ) & especially how the selected jar updates to match the page.

javadoc-single-line
  • Should the search bar be on the right, not the left? I was thinking left, to make it the most prominent input control.
  • The min width seems quite larger - could this be reduced?
    • I think an HBox is being used for the title bar currently; did you compare this with a ToolBar? A ToolBar should make it possible to shrink further and add extra buttons to access options that don't fit, but I'm not certain if this would be a good or a bad thing.

Pinging @finglis and @alanocallaghan for their thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants