Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky integration test by adding one more check #239

Merged

Conversation

lubronzhan
Copy link
Contributor

@lubronzhan lubronzhan commented May 2, 2024

What this PR does / why we need it:
Add check of lb.ingress length. In case it will fail like this
https://github.com/vmware-tanzu/load-balancer-operator-for-kubernetes/actions/runs/8930964320/job/24532158192?pr=237

•! Panic [1.013 seconds]
Integration tests
/home/runner/work/load-balancer-operator-for-kubernetes/load-balancer-operator-for-kubernetes/pkg/test/builder/test_suite.go:153
  ClusterController Test
  /home/runner/work/load-balancer-operator-for-kubernetes/load-balancer-operator-for-kubernetes/controllers/cluster/suite_test.go:68
    EnsureHAService
    /home/runner/work/load-balancer-operator-for-kubernetes/load-balancer-operator-for-kubernetes/controllers/cluster/cluster_intg_test.go:26
      when Avi is HA provider
      /home/runner/work/load-balancer-operator-for-kubernetes/load-balancer-operator-for-kubernetes/controllers/cluster/cluster_intg_test.go:73
        when FQDN HA service endpoint exist
        /home/runner/work/load-balancer-operator-for-kubernetes/load-balancer-operator-for-kubernetes/controllers/cluster/cluster_intg_test.go:109
          should create service and endpoint when FQDN is resolved [It]
          /home/runner/work/load-balancer-operator-for-kubernetes/load-balancer-operator-for-kubernetes/controllers/cluster/cluster_intg_test.go:134

          Test Panicked
          runtime error: index out of range [0] with length 0
          /home/runner/go/pkg/mod/github.com/onsi/[email protected]/internal/async_assertion.go:321

          Full Stack Trace
          github.com/onsi/gomega/internal.(*AsyncAssertion).buildActualPoller.func3.1()

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Special notes for your reviewer:

Release note:


New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.

Signed-off-by: Lubron Zhan <[email protected]>
@lubronzhan lubronzhan changed the title Fix flaky test Fix flaky integration test by adding one more check May 2, 2024
@lubronzhan lubronzhan merged commit 9fe1641 into vmware-tanzu:main May 2, 2024
5 checks passed
@lubronzhan lubronzhan deleted the topic/lubron/fix-intg-test branch May 2, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants