This repository was archived by the owner on Oct 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 193
Use build-tooling to build FeatureGates component #4450
Merged
avi-08
merged 2 commits into
vmware-tanzu:feature/runtime-core
from
avi-08:featureGatesBuildTooling
Mar 24, 2023
Merged
Use build-tooling to build FeatureGates component #4450
avi-08
merged 2 commits into
vmware-tanzu:feature/runtime-core
from
avi-08:featureGatesBuildTooling
Mar 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @avi-08! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better. |
sathyanarays
reviewed
Mar 3, 2023
86b451b
to
3683867
Compare
yharish991
reviewed
Mar 15, 2023
yharish991
reviewed
Mar 15, 2023
42e71cd
to
e9d43c0
Compare
sathyanarays
approved these changes
Mar 16, 2023
yharish991
reviewed
Mar 16, 2023
d11004d
to
a628dee
Compare
Signed-off-by: Avi Sharma <[email protected]>
a628dee
to
09e2c1a
Compare
Signed-off-by: Avi Sharma <[email protected]>
yharish991
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! thanks for the changes
rajathagasthya
pushed a commit
to rajathagasthya/tanzu-framework
that referenced
this pull request
Apr 26, 2023
* Build featuregates using build-tooling Signed-off-by: Avi Sharma <[email protected]> * Restore capabilities module references Signed-off-by: Avi Sharma <[email protected]> --------- Signed-off-by: Avi Sharma <[email protected]>
rajathagasthya
pushed a commit
that referenced
this pull request
Apr 29, 2023
* Build featuregates using build-tooling Signed-off-by: Avi Sharma <[email protected]> * Restore capabilities module references Signed-off-by: Avi Sharma <[email protected]> --------- Signed-off-by: Avi Sharma <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR uses build tooling to build featuregates component. Changes:
Which issue(s) this PR fixes
Fixes #4449
Describe testing done for PR
Ran
make docker-build-all -f build-tooling.mk
from project root and verified successful creation of the FeatureGates component images.Release note
Additional information
Special notes for your reviewer