Skip to content
This repository was archived by the owner on Oct 10, 2023. It is now read-only.

Use build-tooling to build FeatureGates component #4450

Merged

Conversation

avi-08
Copy link
Contributor

@avi-08 avi-08 commented Mar 3, 2023

What this PR does / why we need it

This PR uses build tooling to build featuregates component. Changes:

  • Template the base Dockerfile for every component, so that dependencies within the project can be resolved locally
  • Add another layer for copying component's module code, instead of mounting the entire context.
  • Revert changes to capabilities go.mod files so that it refers to local dependencies.

Which issue(s) this PR fixes

Fixes #4449

Describe testing done for PR

Ran make docker-build-all -f build-tooling.mk from project root and verified successful creation of the FeatureGates component images.

Release note


Additional information

Special notes for your reviewer

@avi-08 avi-08 requested review from a team as code owners March 3, 2023 09:31
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Hi @avi-08! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better.

@avi-08 avi-08 force-pushed the featureGatesBuildTooling branch from 86b451b to 3683867 Compare March 10, 2023 13:30
@avi-08 avi-08 requested a review from rajathagasthya March 14, 2023 12:18
@avi-08 avi-08 force-pushed the featureGatesBuildTooling branch from 42e71cd to e9d43c0 Compare March 16, 2023 06:43
@avi-08 avi-08 force-pushed the featureGatesBuildTooling branch 4 times, most recently from d11004d to a628dee Compare March 23, 2023 09:35
@avi-08 avi-08 force-pushed the featureGatesBuildTooling branch from a628dee to 09e2c1a Compare March 23, 2023 09:36
Copy link
Member

@yharish991 yharish991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! thanks for the changes

@avi-08 avi-08 merged commit 3de63b1 into vmware-tanzu:feature/runtime-core Mar 24, 2023
@avi-08 avi-08 deleted the featureGatesBuildTooling branch March 24, 2023 04:29
rajathagasthya pushed a commit to rajathagasthya/tanzu-framework that referenced this pull request Apr 26, 2023
* Build featuregates using build-tooling

Signed-off-by: Avi Sharma <[email protected]>

* Restore capabilities module references

Signed-off-by: Avi Sharma <[email protected]>

---------

Signed-off-by: Avi Sharma <[email protected]>
rajathagasthya pushed a commit that referenced this pull request Apr 29, 2023
* Build featuregates using build-tooling

Signed-off-by: Avi Sharma <[email protected]>

* Restore capabilities module references

Signed-off-by: Avi Sharma <[email protected]>

---------

Signed-off-by: Avi Sharma <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants