Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for scenarios where access_token is not returned #952

Merged
merged 5 commits into from
Mar 1, 2021
Merged

Support for scenarios where access_token is not returned #952

merged 5 commits into from
Mar 1, 2021

Conversation

shibayan
Copy link
Contributor

Proposed changes

Support for scenarios where access_token is not returned (only id_token / refresh_token is returned). Changed to make it an error if both access_token and id_token are not returned.
AzureAD/microsoft-authentication-library-for-objc#852

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@shibayan shibayan requested a review from a team as a code owner February 24, 2021 10:22
@shibayan shibayan changed the title Verify idtoken Support for scenarios where access_token is not returned Feb 24, 2021
@shibayan shibayan mentioned this pull request Feb 26, 2021
Merged
9 tasks
@oldalton oldalton changed the base branch from dev to external-dev March 1, 2021 19:55
@oldalton oldalton merged commit 3d98c93 into AzureAD:external-dev Mar 1, 2021
@oldalton oldalton mentioned this pull request Mar 1, 2021
Merged
9 tasks
@shibayan shibayan deleted the verify-idtoken branch March 2, 2021 03:11
oldalton added a commit that referenced this pull request Mar 18, 2021
@oldalton
Merge pull request #958 from AzureAD/external-dev
03e608f 
Merging #952 (Support for scenarios where access_token is not returned)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oldalton oldalton oldalton approved these changes

@ameyapat ameyapat Awaiting requested review from ameyapat

@aherciya aherciya Awaiting requested review from aherciya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shibayan @oldalton