-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): add feature flag audit log table to tags dist drawer #87251
Conversation
static/app/views/issueDetails/groupFeatureFlags/flagDetailsDrawerContent.tsx
Outdated
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/flagDetailsDrawerContent.tsx
Outdated
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/groupFeatureFlagsDrawerContent.tsx
Outdated
Show resolved
Hide resolved
static/app/views/settings/featureFlags/changeTracking/organizationFeatureFlagsAuditLogTable.tsx
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/flagDetailsDrawerContent.tsx
Outdated
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/flagDetailsDrawerContent.tsx
Outdated
Show resolved
Hide resolved
4b46b96
to
31e352b
Compare
static/app/views/issueDetails/groupFeatureFlags/flagDetailsDrawerContent.tsx
Outdated
Show resolved
Hide resolved
c755577
to
5ecac35
Compare
5ecac35
to
e73a5c4
Compare
static/app/views/issueDetails/groupFeatureFlags/flagDetailsDrawerContent.tsx
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/flagDetailsLink.tsx
Outdated
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/groupFeatureFlagsDrawerContent.tsx
Outdated
Show resolved
Hide resolved
static/app/views/issueDetails/groupFeatureFlags/groupFeatureFlagsDrawerContent.tsx
Outdated
Show resolved
Hide resolved
95c1ad7
to
24d9343
Compare
static/app/views/issueDetails/groupFeatureFlags/flagDetailsDrawerContent.tsx
Outdated
Show resolved
Hide resolved
return ( | ||
<EmptyStateContainer> | ||
<StyledEmptyStateWarning withIcon={false} small> | ||
{t('No audit logs were found for this feature flag.')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the actions. like searching issues from this view.
but is "audit log" the right term?
other options would be "flag change history" or something.
terminology also needs to align with what we use in the settings page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥
closes https://github.com/getsentry/team-replay/issues/559
flag details:
search actions:
no audit log records:
example flow:
trimmed.mov