Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): add feature flag audit log table to tags dist drawer #87251

Merged
merged 15 commits into from
Mar 19, 2025

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Mar 17, 2025

closes https://github.com/getsentry/team-replay/issues/559

flag details:

SCR-20250317-ophm

search actions:

SCR-20250317-opjz

no audit log records:

SCR-20250318-kyrq

example flow:

trimmed.mov

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 17, 2025
@michellewzhang michellewzhang marked this pull request as ready for review March 17, 2025 23:37
@michellewzhang michellewzhang requested a review from a team as a code owner March 17, 2025 23:37
@michellewzhang michellewzhang requested a review from a team March 17, 2025 23:37
@michellewzhang michellewzhang force-pushed the mz/add-flags-audit-log-drawer branch from 4b46b96 to 31e352b Compare March 18, 2025 18:43
@getsentry getsentry deleted a comment from codecov bot Mar 18, 2025
@michellewzhang michellewzhang force-pushed the mz/add-flags-audit-log-drawer branch from 5ecac35 to e73a5c4 Compare March 18, 2025 21:05
return (
<EmptyStateContainer>
<StyledEmptyStateWarning withIcon={false} small>
{t('No audit logs were found for this feature flag.')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the actions. like searching issues from this view.
but is "audit log" the right term?

other options would be "flag change history" or something.

terminology also needs to align with what we use in the settings page

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCR-20250319-jatz in our settings we call it "audit logs"

Copy link
Member

@aliu39 aliu39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@michellewzhang michellewzhang merged commit a7c7964 into master Mar 19, 2025
40 checks passed
@michellewzhang michellewzhang deleted the mz/add-flags-audit-log-drawer branch March 19, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants